[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/10] scsi-disk: Complete failed requests in scsi_d
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 03/10] scsi-disk: Complete failed requests in scsi_disk_emulate_command |
Date: |
Thu, 4 Nov 2010 14:15:32 +0100 |
This pulls the request completion for error cases from the caller to
scsi_disk_emulate_command. This should not change semantics, but allows to
reuse scsi_handle_write_error() for flushes in the next patch.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
hw/scsi-disk.c | 21 ++++++++++-----------
1 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 43a5b59..96acfe3 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -784,8 +784,9 @@ static int scsi_disk_emulate_read_toc(SCSIRequest *req,
uint8_t *outbuf)
return toclen;
}
-static int scsi_disk_emulate_command(SCSIRequest *req, uint8_t *outbuf)
+static int scsi_disk_emulate_command(SCSIDiskReq *r, uint8_t *outbuf)
{
+ SCSIRequest *req = &r->req;
SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, req->dev);
uint64_t nb_sectors;
int buflen = 0;
@@ -943,12 +944,12 @@ static int scsi_disk_emulate_command(SCSIRequest *req,
uint8_t *outbuf)
return buflen;
not_ready:
- scsi_req_set_status(req, CHECK_CONDITION, NOT_READY);
- return 0;
+ scsi_command_complete(r, CHECK_CONDITION, NOT_READY);
+ return -1;
illegal_request:
- scsi_req_set_status(req, CHECK_CONDITION, ILLEGAL_REQUEST);
- return 0;
+ scsi_command_complete(r, CHECK_CONDITION, ILLEGAL_REQUEST);
+ return -1;
}
/* Execute a scsi command. Returns the length of the data expected by the
@@ -1056,14 +1057,12 @@ static int32_t scsi_send_command(SCSIDevice *d,
uint32_t tag,
case REPORT_LUNS:
case VERIFY:
case REZERO_UNIT:
- rc = scsi_disk_emulate_command(&r->req, outbuf);
- if (rc > 0) {
- r->iov.iov_len = rc;
- } else {
- scsi_req_complete(&r->req);
- scsi_remove_request(r);
+ rc = scsi_disk_emulate_command(r, outbuf);
+ if (rc < 0) {
return 0;
}
+
+ r->iov.iov_len = rc;
break;
case READ_6:
case READ_10:
--
1.7.2.3
- [Qemu-devel] [PULL 00/10] Block patches, Kevin Wolf, 2010/11/04
- [Qemu-devel] [PATCH 01/10] scsi-disk: Implement rerror option, Kevin Wolf, 2010/11/04
- [Qemu-devel] [PATCH 02/10] block: Allow bdrv_flush to return errors, Kevin Wolf, 2010/11/04
- [Qemu-devel] [PATCH 03/10] scsi-disk: Complete failed requests in scsi_disk_emulate_command,
Kevin Wolf <=
- [Qemu-devel] [PATCH 05/10] vpc: Implement bdrv_flush, Kevin Wolf, 2010/11/04
- [Qemu-devel] [PATCH 04/10] scsi-disk: Implement werror for flushes, Kevin Wolf, 2010/11/04
- [Qemu-devel] [PATCH 06/10] qcow2: Invalidate cache after failed read, Kevin Wolf, 2010/11/04
- [Qemu-devel] [PATCH 08/10] ide: Handle immediate bdrv_aio_flush failure, Kevin Wolf, 2010/11/04
- [Qemu-devel] [PATCH 07/10] block: avoid a warning on 64 bit hosts with long as int64_t, Kevin Wolf, 2010/11/04
- [Qemu-devel] [PATCH 10/10] scsi-disk: Fix immediate failure of bdrv_aio_*, Kevin Wolf, 2010/11/04
- [Qemu-devel] [PATCH 09/10] virtio-blk: Handle immediate flush failure properly, Kevin Wolf, 2010/11/04
- [Qemu-devel] Re: [PULL 00/10] Block patches, Anthony Liguori, 2010/11/04