[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bu
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus. |
Date: |
Thu, 11 Nov 2010 17:05:11 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote:
> On 11/10/10 18:34, Michael S. Tsirkin wrote:
> >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote:
> >>
> >>Signed-off-by: Gleb Natapov<address@hidden>
> >
> >Good stuff. We should also consider using this for
> >CLI and monitor. Some comments below.
>
> Oh, we already have a table to map pci classes to descriptions for
> 'info pci'.
You remind me, that one must be fixed to use names from
pci_ids.h
> I'd strongly suggest to just add the fw names to that
> table instead of creating a second one ...
>
> cheers,
> Gerd
No, I mean the path.
We are currently passing domain:bus:slot.function
to point at a device and we know it's broken for
nested bridges and kind of broken for multiple domains.
It's a bug that we must fix.
Class names aren't that interesting to me,
and I'd be just as happy with packing these into 2 tables as a single
one personally, it all seems to be a matter of style.
--
MST
[Qemu-devel] [PATCHv3 12/14] Add bootindex parameter to pci assigned device., Gleb Natapov, 2010/11/10
[Qemu-devel] [PATCHv3 09/14] Record which USBDevice USBPort belongs too., Gleb Natapov, 2010/11/10
[Qemu-devel] [PATCHv3 05/14] Store IDE bus id in IDEBus structure for easy access., Gleb Natapov, 2010/11/10
[Qemu-devel] [PATCHv3 14/14] Pass boot device list to firmware., Gleb Natapov, 2010/11/10