[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv5 01/15] Introduce fw_name field to DeviceInfo s
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [PATCHv5 01/15] Introduce fw_name field to DeviceInfo structure. |
Date: |
Tue, 16 Nov 2010 10:59:25 +0200 |
On Tue, Nov 16, 2010 at 05:09:35PM +0900, Isaku Yamahata wrote:
> On Mon, Nov 15, 2010 at 04:30:55PM +0200, Gleb Natapov wrote:
> > diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> > index b5589b9..38f9d9e 100644
> > --- a/hw/piix_pci.c
> > +++ b/hw/piix_pci.c
> > @@ -365,6 +365,7 @@ static PCIDeviceInfo i440fx_info[] = {
> > static SysBusDeviceInfo i440fx_pcihost_info = {
> > .init = i440fx_pcihost_initfn,
> > .qdev.name = "i440FX-pcihost",
> > + .qdev.fw_name = "pci",
> > .qdev.size = sizeof(I440FXState),
> > .qdev.no_user = 1,
> > };
>
> There are other pci host bridges for not pc architecture
> which needs similar modification.
Yes, I know. This patch doesn't try to add fw_name everywhere it is
needed, just for x86 for now. Things can be added incrementally.
> Please grep by pci_register_bus().
> - apb_pci.c
> - bonito.c
> - grackle_pci.c
> - unin_pci.c
> - versatile_pci.c
I'll look into using BusInfo->name if fw_name is not available. Then all
pci buses will work.
>
> BTW, what happens for non-qdevfied pci host bridge?
They should be converted someday.
--
Gleb.
- [Qemu-devel] [PATCHv5 00/15] boot order specification, Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 04/15] Add get_fw_dev_path callback to ISA bus in qdev., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 06/15] Add get_fw_dev_path callback to IDE bus., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 02/15] Introduce new BusInfo callback get_fw_dev_path., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 03/15] Keep track of ISA ports ISA device is using in qdev., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 07/15] Add get_dev_path callback for system bus., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 01/15] Introduce fw_name field to DeviceInfo structure., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 12/15] Change fw_cfg_add_file() to get full file path as a parameter., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 08/15] Add get_fw_dev_path callback for pci bus., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 09/15] Record which USBDevice USBPort belongs too., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 10/15] Add get_dev_path callback for usb bus., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 05/15] Store IDE bus id in IDEBus structure for easy access., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 14/15] Add notifier that will be called when machine is fully created., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 15/15] Pass boot device list to firmware., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 13/15] Add bootindex for option roms., Gleb Natapov, 2010/11/15
- [Qemu-devel] [PATCHv5 11/15] Add bootindex parameter to net/block/fd device, Gleb Natapov, 2010/11/15