Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

[Daniel P. Berrange]

On Tue, Nov 16, 2010 at 09:46:20AM -0600, Anthony Liguori wrote:
> On 11/08/2010 01:33 PM, Daniel P. Berrange wrote:
> >This introduces a new tracing backend that targets the SystemTAP
> >implementation of DTrace userspace tracing. The core functionality
> >should be applicable and standard across any DTrace implementation
> >on Solaris, OS-X, *BSD, but the Makefile rules will likely need
> >some small additional changes to cope with OS specific build
> >requirements.
> >
> >This backend builds a little differently from the other tracing
> >backends. Specifically there is no 'trace.c' file, because the
> >'dtrace' command line tool generates a '.o' file directly from
> >the dtrace probe definition file. The probe definition is usually
> >named with a '.d' extension but QEMU uses '.d' files for its
> >external makefile dependancy tracking, so this uses '.dtrace' as
> >the extension for the probe definition file.
> >
> >The 'tracetool' program gains the ability to generate a trace.h
> >file for DTrace, and also to generate the trace.d file containing
> >the dtrace probe definition.
> >
> >Example usage of a dtrace probe in systemtap looks like:
> >
> >   probe process("qemu").mark("qemu_malloc") {
> >     printf("Malloc %d %p\n", $arg1, $arg2);
> >   }
> >
> >* .gitignore: Ignore trace-dtrace.*
> >* Makefile: Extra rules for generating DTrace files
> >* Makefile.obj: Don't build trace.o for DTrace, use
> >   trace-dtrace.o generated by 'dtrace' instead
> >* tracetool: Support for generating DTrace data files
> >
> >Signed-off-by: Daniel P. Berrange<address@hidden>
> >   
> 
> Applied both.  Thanks.


I'm afraid you have applied an old version of the patches. Please
revert these, and apply version 6, from Nov 12th

http://lists.gnu.org/archive/html/qemu-devel/2010-11/msg01033.html

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|