qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Force object directory use


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH] Force object directory use
Date: Wed, 17 Nov 2010 19:08:04 +0000

On Tue, Nov 16, 2010 at 10:37 PM, Peter Maydell
<address@hidden> wrote:
> On 16 November 2010 21:59, Blue Swirl <address@hidden> wrote:
>> If the user attempts to run 'configure' in the source tree,
>> create an object directory and configure that instead.
>>
>> Rename topmost Makefile to Makefile.top. Add a new Makefile, which
>> is only used when user attempts to run 'make' in the source tree.
>
> [Something seems to have line-wrapped this patch so it won't
> apply (not just me, http://patchwork.ozlabs.org/patch/71463/
> has line-wrap damage too).]
>
> Minor nit: I think the patch as it stands breaks the "Please
> call configure before running make!" user-error guard, doesn't
> it?

Yes. I'll send an updated version.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]