[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 08/10] ahci: add ahci emulation
From: |
Alexander Graf |
Subject: |
[Qemu-devel] Re: [PATCH 08/10] ahci: add ahci emulation |
Date: |
Thu, 18 Nov 2010 19:05:33 +0100 |
User-agent: |
Thunderbird 2.0.0.23 (X11/20090817) |
Gerd Hoffmann wrote:
> Hi,
>
>> +static void ahci_trigger_irq(AHCIState *s, AHCIDevice *d,
>> + int irq_type)
>
>> +static void ahci_check_irq(AHCIState *s)
>
> MSI support would be nice to have.
Alrighty, I added MSI support. But I only have a single vector in use
atm as nvec > 0 doesn't get written to the PCI config space so the code
trips on that later on.
[...]
>
>> + if (dinfo) {
>> + ide_create_drive(&ad->port, 0, dinfo);
>> + }
>
> That doesn't belong into the qdev init function.
>
> Look how ide/isa.c handles it: The qdev init function
> (isa_ide_initfn) doesn't create ide-drives at all. And there is a
> convinience function (isa_ide_init) which first creates the
> controller, then attaches the drives. The later is called from
> pc_init() with the drives specified via -drive if=ide (or -hda).
Hrm. I guess I'll just put it into the PC specific initialization
function :).
>
> Does AHCI support drive hotplug btw?
AHCI does, my code does not yet :). Feel free to add support for it! :D
Alex
- [Qemu-devel] [PATCH 09/10] ahci: add -drive support, (continued)
- [Qemu-devel] [PATCH 09/10] ahci: add -drive support, Alexander Graf, 2010/11/17
- [Qemu-devel] [PATCH 01/10] ide: split ide command interpretation off, Alexander Graf, 2010/11/17
- [Qemu-devel] [PATCH 03/10] ide: add support for ide bus ops, Alexander Graf, 2010/11/17
- [Qemu-devel] [PATCH 04/10] ide: add DMA hooks to bus ops, Alexander Graf, 2010/11/17
- [Qemu-devel] [PATCH 05/10] ide: add ncq identify data for ahci sata drives, Alexander Graf, 2010/11/17
- [Qemu-devel] [PATCH 06/10] pci: add storage class for sata, Alexander Graf, 2010/11/17
- [Qemu-devel] [PATCH 10/10] ahci: spawn controller on demand, Alexander Graf, 2010/11/17
- [Qemu-devel] [PATCH 02/10] ide: fix whitespace gap in ide_exec_cmd, Alexander Graf, 2010/11/17
- [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation, Alexander Graf, 2010/11/17
[Qemu-devel] Re: [PATCH 00/10] AHCI emulation support v2, Stefan Hajnoczi, 2010/11/18
Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2, Kevin Wolf, 2010/11/18
Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2, Kevin Wolf, 2010/11/19