[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/16] scsi: Return SAM status codes
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/16] scsi: Return SAM status codes |
|
Date: |
Fri, 19 Nov 2010 19:33:32 +0100 |
|
User-agent: |
Mutt/1.3.28i |
On Thu, Nov 18, 2010 at 03:46:32PM +0100, Hannes Reinecke wrote:
>
> The SCSI emulation is supposed to return status codes as defined
> by SAM, not the linux ones which are shifted by one.
When just looking at the patch the description is rather confusing as
all places touched were already returning the correct value by doing
the opencoded shift. Only a little grepping reveals that there are
lots of other incorrect uses, too. You might consider mentioning
this in the patch description.