[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/16] Allow zero alloc_hint in qemu_sglist_init
|
From: |
Hannes Reinecke |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/16] Allow zero alloc_hint in qemu_sglist_init() |
|
Date: |
Mon, 22 Nov 2010 10:01:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101026 SUSE/3.0.10 Thunderbird/3.0.10 |
On 11/19/2010 07:28 PM, Christoph Hellwig wrote:
> On Thu, Nov 18, 2010 at 03:44:34PM +0100, Hannes Reinecke wrote:
>>
>> qemu_malloc doesn't check for zero argument, so we need to
>> check ourselves.
>
> I'm not sure if it's a that good idea to remove the implicit
> ->sg != NULL assumption. Any reason you can't simply call
> qemu_sglist_init later?
>
We can actually drop this. It's a leftover from the old interface.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
address@hidden +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)