Re: [Qemu-devel] [PATCH] Make SCSI HBA configurable

[Alexander Graf]

On 22.11.2010, at 16:05, Jes Sorensen wrote:

> On 11/22/10 11:15, Hannes Reinecke wrote:
>> 
>> This patch introduces configuration variables
>> CONFIG_SCSI_LSI
>> CONFIG_SCSI_MEGASAS
>> and renames the existing CONFIG_ESP to CONFIG_SCSI_ESP.
>> With this the available SCSI HBAs can be configured for each
>> target configuration instead of compiling it in for everyone.
>> 
>> Signed-off-by: Hannes Reinecke <address@hidden>
>> ---
>> Makefile.objs                        |    5 +++--
>> default-configs/i386-softmmu.mak     |    2 ++
>> default-configs/mips-softmmu.mak     |    2 +-
>> default-configs/mips64-softmmu.mak   |    2 +-
>> default-configs/mips64el-softmmu.mak |    2 +-
>> default-configs/mipsel-softmmu.mak   |    2 +-
>> default-configs/ppc-softmmu.mak      |    2 ++
>> default-configs/ppc64-softmmu.mak    |    2 ++
>> default-configs/ppcemb-softmmu.mak   |    2 ++
>> default-configs/sparc-softmmu.mak    |    2 +-
>> default-configs/sparc64-softmmu.mak  |    2 ++
>> default-configs/x86_64-softmmu.mak   |    2 ++
>> 12 files changed, 20 insertions(+), 7 deletions(-)
> 
> Acked-by: Jes Sorensen <address@hidden>
> 
> With a configure flag to flip modify the list from the default it would
> reach perfect status :)

We don't have that for any device yet that's represented in the 
default-configs. I'd actually rather advocate to go with a make menuconfig + 
Kconfig style format here instead of configure options.


Alex