[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant |
Date: |
Wed, 24 Nov 2010 13:04:26 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 24, 2010 at 11:52:25AM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" <address@hidden> wrote:
> > On Wed, Nov 24, 2010 at 12:02:59AM +0100, Juan Quintela wrote:
> >> From: Juan Quintela <address@hidden>
>
> >> diff --git a/buffered_file.h b/buffered_file.h
> >> index 98d358b..a728316 100644
> >> --- a/buffered_file.h
> >> +++ b/buffered_file.h
> >> @@ -21,6 +21,8 @@ typedef void (BufferedPutReadyFunc)(void *opaque);
> >> typedef void (BufferedWaitForUnfreezeFunc)(void *opaque);
> >> typedef int (BufferedCloseFunc)(void *opaque);
> >>
> >> +extern const int buffered_file_interval;
> >> +
> >
> > This shouldn't be exported, IMO.
>
> What do you want? an accessor function?
I mean an abstraction at qemu_file_ level.
> Notice that it is a constant.
> We need the value in other places, see the last patch.
>
> Otherwise, I have to pick random numbers like ... 50ms.
>
> Later, Juan.
If you need a random number, use a random number :)
>
> >
> >> QEMUFile *qemu_fopen_ops_buffered(void *opaque, size_t xfer_limit,
> >> BufferedPutFunc *put_buffer,
> >> BufferedPutReadyFunc *put_ready,
> >> --
> >> 1.7.3.2
> >>
- [Qemu-devel] [PATCH 00/10] Fix migration with lots of memory, Juan Quintela, 2010/11/23
- [Qemu-devel] [PATCH 02/10] Add buffered_file_internal constant, Juan Quintela, 2010/11/23
- Message not available
- Message not available
- [Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant, Anthony Liguori, 2010/11/30
- [Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant, Juan Quintela, 2010/11/30
- [Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant, Michael S. Tsirkin, 2010/11/30
- [Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant, Juan Quintela, 2010/11/30
- [Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant, Anthony Liguori, 2010/11/30
- [Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant, Juan Quintela, 2010/11/30
- [Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant, Anthony Liguori, 2010/11/30
- [Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant, Juan Quintela, 2010/11/30