[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] usb-linux: We only need to keep track of 15 end
From: |
Hans de Goede |
Subject: |
[Qemu-devel] [PATCH 6/7] usb-linux: We only need to keep track of 15 endpoints |
Date: |
Fri, 26 Nov 2010 19:13:22 +0100 |
Currently we reserve room for endpoint data for 16 endpoints, but given
that we only use endpoint data for endpoints 1-15, and always index the
array with the endpoint-number - 1, 15 is enough.
Signed-off-by: Hans de Goede <address@hidden>
---
usb-linux.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/usb-linux.c b/usb-linux.c
index 5a979bd..9301084 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -78,7 +78,7 @@ typedef int USBScanFunc(void *opaque, int bus_num, int addr,
int devpath,
#define USBPROCBUS_PATH "/proc/bus/usb"
#define PRODUCT_NAME_SZ 32
-#define MAX_ENDPOINTS 16
+#define MAX_ENDPOINTS 15
#define USBDEVBUS_PATH "/dev/bus/usb"
#define USBSYSBUS_PATH "/sys/bus/usb"
@@ -724,7 +724,7 @@ static int usb_host_set_interface(USBHostDevice *s, int
iface, int alt)
struct usbdevfs_setinterface si;
int i, ret;
- for (i = 1; i < MAX_ENDPOINTS; i++) {
+ for (i = 1; i <= MAX_ENDPOINTS; i++) {
if (is_isoc(s, i)) {
usb_host_stop_n_free_iso(s, i);
}
@@ -1275,7 +1275,7 @@ static int usb_host_close(USBHostDevice *dev)
qemu_set_fd_handler(dev->fd, NULL, NULL, NULL);
dev->closing = 1;
- for (i = 1; i < MAX_ENDPOINTS; i++) {
+ for (i = 1; i <= MAX_ENDPOINTS; i++) {
if (is_isoc(dev, i)) {
usb_host_stop_n_free_iso(dev, i);
}
--
1.7.3.2
- [Qemu-devel] [PATCH 1/7] usb-linux: introduce a usb_linux_alt_setting function, Hans de Goede, 2010/11/26
- [Qemu-devel] [PATCH 2/7] usb-linux: Get the alt. setting from sysfs rather then asking the dev, Hans de Goede, 2010/11/26
- [Qemu-devel] [PATCH 3/7] usb-linux: Add support for buffering iso usb packets, Hans de Goede, 2010/11/26
- [Qemu-devel] [PATCH 4/7] usb-linux: Refuse packets for endpoints which are not in the usb descriptor, Hans de Goede, 2010/11/26
- [Qemu-devel] [PATCH 5/7] usb-linux: Refuse iso packets when max packet size is 0 (alt setting 0), Hans de Goede, 2010/11/26
- [Qemu-devel] [PATCH 6/7] usb-linux: We only need to keep track of 15 endpoints,
Hans de Goede <=
- [Qemu-devel] [PATCH 7/7] usb-linux: Add support for buffering iso out usb packets, Hans de Goede, 2010/11/26