[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 07/10] ram_save_remaining() returns an uint64_t

From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 07/10] ram_save_remaining() returns an uint64_t
Date: Tue, 30 Nov 2010 08:21:15 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6

On 11/30/2010 03:06 AM, Anthony Liguori wrote:

-static ram_addr_t ram_save_remaining(void)
+static uint64_t ram_save_remaining(void)
      RAMBlock *block;
-    ram_addr_t count = 0;
+    uint64_t count = 0;

      QLIST_FOREACH(block,&ram_list.blocks, next) {
          ram_addr_t addr;

No, it returns a count of bytes of ram which is a subset of ram_addr_t's
space.  The unit is definitely right here.

It returns a count of pages, actually, which is a different unit. For example, in practice it can fit in 32 bits even (though I'm not saying we should make it uint32_t; we'd be dangerously close to the limit for the guest sizes that Juan is handling).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]