[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] blockdev: check dinfo ptr before using
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] Re: [PATCH] blockdev: check dinfo ptr before using |
Date: |
Fri, 10 Dec 2010 16:05:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 08.12.2010 17:05, schrieb Ryan Harper:
> If a user decides to punish a guest by revoking its block device via
> drive_del, and subsequently also attempts to remove the pci device
> backing it, and the device is using blockdev_auto_del() then we get a
> segfault when we attempt to access dinfo->auto_del.[1]
>
> The fix is to check if drive_get_by_blockdev() actually returns a valid
> dinfo pointer or not.
>
> 1. (qemu) pci_add auto storage
> file=images/test01.raw,if=virtio,id=block1,snapshot=on
> (qemu) drive_del block1
> (qemu) pci_del 5
> *segfault*
>
> Signed-off-by: Ryan Harper <address@hidden>
Thanks, applied to the block branch.
Kevin