[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v4 0/2] Minimal RAM API support

From: Alex Williamson
Subject: [Qemu-devel] [PATCH v4 0/2] Minimal RAM API support
Date: Mon, 13 Dec 2010 14:24:23 -0700
User-agent: StGIT/0.14.3

Update per comments, Thanks,



 - ram_slot -> RamSlot (per CODING_STYLE)
 - drop qemu_ prefix from functions (per CODING_STYLE)
 - mallocz -> malloc
 - drop extraneous return from void function


 - Address review comments
 - pc registers all memory below 4G in one chunk

Let me know if there are any further issues.


 - Move to Makefile.objs
 - Move structures to memory.c and create a callback function
 - Fix memory leak

I haven't moved to the state parameter because there should only
be a single instance of this per VM.  The state parameter seems
like it would add complications in setup and function calling, but
maybe point me to an example if I'm off base.


For VFIO based device assignment, we need to know what guest memory
areas are actual RAM.  RAMBlocks have long since become a grab bag
of misc allocations, so aren't effective for this.  Anthony has had
a RAM API in mind for a while now that addresses this problem.  This
implements just enough of it so that we have an interface to get
actual guest memory physical addresses to setup the host IOMMU.  We
can continue building a full RAM API on top of this stub.

Anthony, feel free to add copyright to memory.c as it's based on
your initial implementation.  I had to add something since the file
in your branch just copies a header with Frabrice's copywrite.


Alex Williamson (2):
      RAM API: Make use of it for x86 PC
      Minimal RAM API support

 Makefile.objs |    1 +
 cpu-common.h  |    2 +
 hw/pc.c       |    9 ++---
 memory.c      |   94 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 memory.h      |   44 +++++++++++++++++++++++++++
 5 files changed, 144 insertions(+), 6 deletions(-)
 create mode 100644 memory.c
 create mode 100644 memory.h

reply via email to

[Prev in Thread] Current Thread [Next in Thread]