[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] scsi-disk: support WRITE SAME (16) with unm
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] scsi-disk: support WRITE SAME (16) with unmap bit |
Date: |
Thu, 16 Dec 2010 17:41:02 +0100 |
User-agent: |
Mutt/1.3.28i |
On Thu, Dec 16, 2010 at 04:48:15PM +0100, Kevin Wolf wrote:
> > + scsi_req_set_status(r, GOOD, NO_SENSE);
> > + scsi_req_complete(&r->req);
> > + scsi_remove_request(r);
>
> Isn't this the same as scsi_command_complete()?
Yes.
>
> > + return 0;
>
> And if you break; here instead of returning (like all other commands)
> and remove the three lines above completely, I think it would just do
> the right thing.
Yes, that looks doable.
- [Qemu-devel] ]PATCH 0/7] add TRIM/UNMAP support, v3, Christoph Hellwig, 2010/12/10
- [Qemu-devel] [PATCH 1/7] block: add discard support, Christoph Hellwig, 2010/12/10
- [Qemu-devel] [PATCH 2/7] scsi-disk: support WRITE SAME (16) with unmap bit, Christoph Hellwig, 2010/12/10
- [Qemu-devel] [PATCH 3/7] make dma_bdrv_io available to drivers, Christoph Hellwig, 2010/12/10
- [Qemu-devel] [PATCH 4/7] ide: factor dma handling helpers, Christoph Hellwig, 2010/12/10
- [Qemu-devel] [PATCH 5/7] ide: also reset io_buffer_index for writes, Christoph Hellwig, 2010/12/10
- [Qemu-devel] [PATCH 6/7] ide: add TRIM support, Christoph Hellwig, 2010/12/10
- [Qemu-devel] [PATCH 7/7] raw-posix: add discard support, Christoph Hellwig, 2010/12/10
- Re: [Qemu-devel] ]PATCH 0/7] add TRIM/UNMAP support, v3, Stefan Hajnoczi, 2010/12/12
- Re: [Qemu-devel] ]PATCH 0/7] add TRIM/UNMAP support, v3, Kevin Wolf, 2010/12/16
- [Qemu-devel] Re: [PATCH 0/3] add TRIM/UNMAP support, v4, Christoph Hellwig, 2010/12/16