qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/7] scsi-disk: support WRITE SAME (16) with unm


From: Christoph Hellwig
Subject: Re: [Qemu-devel] [PATCH 2/7] scsi-disk: support WRITE SAME (16) with unmap bit
Date: Thu, 16 Dec 2010 17:41:02 +0100
User-agent: Mutt/1.3.28i

On Thu, Dec 16, 2010 at 04:48:15PM +0100, Kevin Wolf wrote:
> > +        scsi_req_set_status(r, GOOD, NO_SENSE);
> > +        scsi_req_complete(&r->req);
> > +        scsi_remove_request(r);
> 
> Isn't this the same as scsi_command_complete()?

Yes.

> 
> > +        return 0;
> 
> And if you break; here instead of returning (like all other commands)
> and remove the three lines above completely, I think it would just do
> the right thing.

Yes, that looks doable.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]