[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QO
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError |
Date: |
Fri, 17 Dec 2010 09:22:34 -0200 |
On Fri, 17 Dec 2010 14:20:15 +0800
Lai Jiangshan <address@hidden> wrote:
> On 12/16/2010 09:17 PM, Luiz Capitulino wrote:
> > On Thu, 16 Dec 2010 15:11:50 +0200
> > Avi Kivity <address@hidden> wrote:
> >>
> >> Why have an argument at all? Always nmi to all cpus.
> >
>
> I think Avi's suggest is better, and I will use
> "inject-nmi" (without cpu-index argument) to send NMI to all cpus,
> like physical GUI. If some one want to send NMI to a set of cpus,
> he can use "inject-nmi" multiple times.
His suggestion is to drop _all_ arguments, right Avi?
This will simplify things, but you'll need a small refactoring to keep
the human monitor behavior (which accepts a cpu index).
> I also like "cpu-index", so I have to add another patch for
> coverting current "cpu_index" to "cpu-index".
>
> Thanks,
> Lai
>
- [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, (continued)
- [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Avi Kivity, 2010/12/16
- [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Luiz Capitulino, 2010/12/16
- [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Avi Kivity, 2010/12/16
- [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Luiz Capitulino, 2010/12/16
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Markus Armbruster, 2010/12/16
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Avi Kivity, 2010/12/16
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Luiz Capitulino, 2010/12/16
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Avi Kivity, 2010/12/16
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Luiz Capitulino, 2010/12/16
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Lai Jiangshan, 2010/12/17
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError,
Luiz Capitulino <=
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Avi Kivity, 2010/12/17
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Lai Jiangshan, 2010/12/20
- Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError, Markus Armbruster, 2010/12/16