[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/17] vl.c: add deleted flag for deleting the handl
From: |
Yoshiaki Tamura |
Subject: |
[Qemu-devel] [PATCH 05/17] vl.c: add deleted flag for deleting the handler. |
Date: |
Fri, 24 Dec 2010 11:55:38 +0900 |
Make deleting handlers robust against deletion of any elements in a
handler by using a deleted flag like in file descriptors.
Signed-off-by: Yoshiaki Tamura <address@hidden>
---
vl.c | 13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 768dbf4..8118194 100644
--- a/vl.c
+++ b/vl.c
@@ -1140,6 +1140,7 @@ static void nographic_update(void *opaque)
struct vm_change_state_entry {
VMChangeStateHandler *cb;
void *opaque;
+ int deleted;
QLIST_ENTRY (vm_change_state_entry) entries;
};
@@ -1160,8 +1161,7 @@ VMChangeStateEntry
*qemu_add_vm_change_state_handler(VMChangeStateHandler *cb,
void qemu_del_vm_change_state_handler(VMChangeStateEntry *e)
{
- QLIST_REMOVE (e, entries);
- qemu_free (e);
+ e->deleted = 1;
}
void vm_state_notify(int running, int reason)
@@ -1170,8 +1170,13 @@ void vm_state_notify(int running, int reason)
trace_vm_state_notify(running, reason);
- for (e = vm_change_state_head.lh_first; e; e = e->entries.le_next) {
- e->cb(e->opaque, running, reason);
+ QLIST_FOREACH(e, &vm_change_state_head, entries) {
+ if (e->deleted) {
+ QLIST_REMOVE (e, entries);
+ qemu_free (e);
+ } else {
+ e->cb(e->opaque, running, reason);
+ }
}
}
--
1.7.1.2
- [Qemu-devel] [PATCH 01/17] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer()., (continued)
- [Qemu-devel] [PATCH 01/17] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer()., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 14/17] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush()., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 10/17] Call init handler of event-tap at main() in vl.c., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 06/17] virtio: update last_avail_idx when inuse is decreased., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 13/17] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async()., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 03/17] Introduce skip_header parameter to qemu_loadvm_state()., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 08/17] savevm: introduce util functions to control ft_trans_file from savevm layer., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 02/17] Introduce read() to FdMigrationState., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 16/17] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 09/17] Introduce event-tap., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 05/17] vl.c: add deleted flag for deleting the handler.,
Yoshiaki Tamura <=
- [Qemu-devel] [PATCH 07/17] Introduce fault tolerant VM transaction QEMUFile and ft_mode., Yoshiaki Tamura, 2010/12/23
- Re: [Qemu-devel] [PATCH 00/19] Kemari for KVM v0.2.1, Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 00/19] Kemari for KVM v0.2.1, Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state()., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 02/19] Introduce read() to FdMigrationState., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 10/19] Call init handler of event-tap at main() in vl.c., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 04/19] qemu-char: export socket_set_nodelay()., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer()., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c., Yoshiaki Tamura, 2010/12/23
- [Qemu-devel] [PATCH 05/19] vl.c: add deleted flag for deleting the handler., Yoshiaki Tamura, 2010/12/23