[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] make_device_config: Fix non-fatal error message

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH] make_device_config: Fix non-fatal error message with dash and other shells
Date: Fri, 31 Dec 2010 00:08:52 +0100

Am 30.12.2010 um 23:04 schrieb Stefan Weil:

ORS=" " adds a blank to the name of the include file.
Some shells (e.g. dash) don't accept input redirection
(tr -d '\r' < $f) when $f ends with a blank, so they
print an error message instead of reading pci.mak.
This is a non-fatal error because pci.mak does not
contain an include line. It was introduced by commit

Using printf avoids adding a blank and is also supported
by older awk versions (this solution was suggested by
Paolo Bonzini, thank you).

Cc: Blue Swirl <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>

Tested-by: Andreas Färber <address@hidden>

`make defconfig; make` working fine on Mac OS X now!


make_device_config.sh |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/make_device_config.sh b/make_device_config.sh
index 596fc5b..5d14885 100644
--- a/make_device_config.sh
+++ b/make_device_config.sh
@@ -18,7 +18,7 @@ process_includes () {

while [ -n "$f" ] ; do
- f=`tr -d '\r' < $f | awk '/^include / {ORS=" "; print "'$src_dir'/" $2}'` + f=`tr -d '\r' < $f | awk '/^include / {printf "'$src_dir'/%s", $2}'`
  [ $? = 0 ] || exit 1
  all_includes="$all_includes $f"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]