Re: [Qemu-devel] [PATCH] noaudio: use audio_pcm_sw_read() in no_read()

[malc]

On Mon, 3 Jan 2011, Michael Walle wrote:

> On Mon, 3 Jan 2011, 23:46:34 malc wrote:
> > On Mon, 3 Jan 2011, Michael Walle wrote:
> > > Instead of returning a self-calculated empty buffer use the proper method
> > > supplied by the audio subsystem. This will fix the return value of the
> > > no_read() function which otherwise returns too many samples because
> > > total_hw_samples_acquired isn't correctly accounted.
> > 
> > What and how is incorrectly accounted? FWIW the audio_pcm_sw_read will
> > perform useless resampling/mixing that's why custom code is used.
> total_hw_samples_acquired is never incremented (see audio_pcm_sw_read()). As 
> a 
> result the noaudio driver returns too many bytes per second.
> 

Okay, then the simpler patch should just increment it by amount in "total"
variable.

-- 
mailto:address@hidden