qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_


From: Jes Sorensen
Subject: [Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t
Date: Wed, 05 Jan 2011 13:36:35 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7

On 01/05/11 13:34, Michael S. Tsirkin wrote:
> On Wed, Jan 05, 2011 at 11:41:02AM +0100, address@hidden wrote:
>> From: Jes Sorensen <address@hidden>
>>
>> strtosz() needs to return a 64 bit type even on 32 bit
>> architectures. Otherwise qemu-img will fail to create disk
>> images >= 2GB
>>
>> Signed-off-by: Jes Sorensen <address@hidden>
> 
> Nothing wrong with this patch, but should the function
> be renamed to strtos64 then?

I don't think that adds any value to be honest. The problem with the old
interface was that the return type differed depending on whether it was
compiled on 32 vs 64 bit systems.

Cheers,
Jes



reply via email to

[Prev in Thread] Current Thread [Next in Thread]