Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

[Avi Kivity]

On 01/10/2011 10:23 PM, Anthony Liguori wrote:
> > > I don't see how ioapic, pit, or pic have a system scope.
> > They are not bound to any CPU like the APIC which you may have in mind.
>
> And none of the above interact with KVM.

They're implemented by kvm.  What deeper interaction do you have in mind?

> They may be replaced by KVM but if you look at the PIT, this is done 
> by having two distinct devices.  The KVM specific device can (and 
> should) be instantiated with kvm_state.
>
> The way the IOAPIC/APIC/PIC is handled in qemu-kvm is nasty.  The 
> kernel devices are separate devices and that should be reflected in 
> the device tree.

I don't see why.  Those are just two different implementations for the 
same guest visible device.  It's like saying IDE should be seen 
differently if it's backed by qcow2 or qed.

The device tree is about the guest view of devices.

--
error compiling committee.c: too many arguments to function