qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID


From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [PATCH v2] add event queueing to USB HID
Date: Wed, 12 Jan 2011 17:27:16 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Red Hat/3.1.7-3.el6_0 Thunderbird/3.1.7

  Hi,

I left the "changed" member in USBHIDState, rather than moving it
to the keyboard, because it is useful to handle the idle period
(in USB_TOKEN_IN) in a device-independent way. Without it the
code became more messy.

This leaves the same information recorded in the driver in two places
and is therefore IMO a bad idea. I still think the way I did this is
best: have a common helper function used by the keyboard and pointer
code to deal with the idle handling.

I don't disagree, but I think this is better left for a separate patch.

Just use a queue for both pointer and keyboard -- problem solved ;)

Need a test case? Connect with vncviewer, press F8, pick "Send Ctrl-Alt-Del" from the menu. Works with ps/2 keyboard. Doesn't work with usb keyboard.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]