Re: [Qemu-devel] [PATCH] Close Gdb stub connection in gdb_exit

[Fabien Chouteau]

On 01/04/2011 11:27 AM, Fabien Chouteau wrote:
> On Windows, this is required to flush the remaining data in the IO stream,
> otherwise Gdb do not receive the last packet.
>
> Signed-off-by: Fabien Chouteau<address@hidden>
> ---
>   gdbstub.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 0aa081b..dac3ce6 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2391,6 +2391,10 @@ void gdb_exit(CPUState *env, int code)
>
>     snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code);
>     put_packet(s, buf);
> +
> +  if (s->chr) {
> +      qemu_chr_close(s->chr);
> +  }
>   }
>
>   #ifdef CONFIG_USER_ONLY

Any comment on this patch?

--
Fabien Chouteau