qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config s


From: Isaku Yamahata
Subject: Re: [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings
Date: Thu, 13 Jan 2011 18:57:25 +0900
User-agent: Mutt/1.5.19 (2009-01-05)

How about creating stub functions instead of #ifdefs?
something like

pc-stubs.c
#ifndef CONFIG_VMWARE_VGA
pci_vmsvga_init()
{
        error ...
}
#endif
#ifndef CONFIG_...
...


On Wed, Jan 12, 2011 at 11:34:29PM -0700, David Ahern wrote:
> David Ahern (8):
>   fix 'no such file' error from make_device_config.sh
>   x86_64 config: fix compile for CONFIG_VMWARE_VGA=n
>   x86_64 config: fix compile for CONFIG_PARALLEL=n
>   remove unused parallel_* variables from pc.c
>   x86_64 config: fix compile for CONFIG_NE2000_ISA=n
>   x86_64 config: fix compile for CONFIG_VGA_ISA=n
>   x86_64 config: fix compile for CONFIG_IDE_ISA=n
>   x86_64 config: fix compile for CONFIG_FDC=n
> 
>  hw/pc.c               |   21 ++++++++++++++++++---
>  hw/pc_piix.c          |   11 +++++++++++
>  make_device_config.sh |    2 +-
>  3 files changed, 30 insertions(+), 4 deletions(-)
> 
> -- 
> 1.7.3.4
> 
> 

-- 
yamahata



reply via email to

[Prev in Thread] Current Thread [Next in Thread]