[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begi
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}. |
Date: |
Thu, 13 Jan 2011 21:16:32 +0000 |
On Thu, Jan 13, 2011 at 5:15 PM, Yoshiaki Tamura
<address@hidden> wrote:
> Introduce qemu_savevm_state_{begin,commit} to send the memory and
> device info together, while avoiding cancelling memory state tracking.
>
> Signed-off-by: Yoshiaki Tamura <address@hidden>
> ---
> savevm.c | 88
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> sysemu.h | 2 +
> 2 files changed, 90 insertions(+), 0 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index ebb3ef8..9d20c37 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1722,6 +1722,94 @@ int qemu_savevm_state_complete(Monitor *mon, QEMUFile
> *f)
> return 0;
> }
>
> +int qemu_savevm_trans_begin(Monitor *mon, QEMUFile *f, int init)
> +{
> + SaveStateEntry *se;
> + int skipped = 0;
> +
> + QTAILQ_FOREACH(se, &savevm_handlers, entry) {
> + int len, stage, ret;
> +
> + if (se->save_live_state == NULL)
> + continue;
Missing braces.
> +
> + /* Section type */
> + qemu_put_byte(f, QEMU_VM_SECTION_START);
> + qemu_put_be32(f, se->section_id);
> +
> + /* ID string */
> + len = strlen(se->idstr);
> + qemu_put_byte(f, len);
> + qemu_put_buffer(f, (uint8_t *)se->idstr, len);
> +
> + qemu_put_be32(f, se->instance_id);
> + qemu_put_be32(f, se->version_id);
> +
> + stage = init ? QEMU_VM_SECTION_START : QEMU_VM_SECTION_PART;
> + ret = se->save_live_state(mon, f, stage, se->opaque);
> + if (!ret) {
> + skipped++;
> + }
> + }
> +
> + if (qemu_file_has_error(f))
> + return -EIO;
Also here
> +
> + return skipped;
> +}
> +
> +int qemu_savevm_trans_complete(Monitor *mon, QEMUFile *f)
> +{
> + SaveStateEntry *se;
> +
> + cpu_synchronize_all_states();
> +
> + QTAILQ_FOREACH(se, &savevm_handlers, entry) {
> + int ret;
> +
> + if (se->save_live_state == NULL)
> + continue;
here
> +
> + /* Section type */
> + qemu_put_byte(f, QEMU_VM_SECTION_PART);
> + qemu_put_be32(f, se->section_id);
> +
> + ret = se->save_live_state(mon, f, QEMU_VM_SECTION_PART, se->opaque);
> + if (!ret) {
> + /* do not proceed to the next vmstate. */
> + return 1;
> + }
> + }
> +
> + QTAILQ_FOREACH(se, &savevm_handlers, entry) {
> + int len;
> +
> + if (se->save_state == NULL && se->vmsd == NULL)
> + continue;
here
> +
> + /* Section type */
> + qemu_put_byte(f, QEMU_VM_SECTION_FULL);
> + qemu_put_be32(f, se->section_id);
> +
> + /* ID string */
> + len = strlen(se->idstr);
> + qemu_put_byte(f, len);
> + qemu_put_buffer(f, (uint8_t *)se->idstr, len);
> +
> + qemu_put_be32(f, se->instance_id);
> + qemu_put_be32(f, se->version_id);
> +
> + vmstate_save(f, se);
> + }
> +
> + qemu_put_byte(f, QEMU_VM_EOF);
> +
> + if (qemu_file_has_error(f))
> + return -EIO;
and here.
- [Qemu-devel] [PATCH 00/19] Kemari for KVM v0.2.4, Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 04/19] qemu-char: export socket_set_nodelay()., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari)., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 16/19] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 05/19] vl.c: add deleted flag for deleting the handler., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}., Yoshiaki Tamura, 2011/01/13
- Re: [Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.,
Blue Swirl <=
- [Qemu-devel] [PATCH 02/19] Introduce read() to FdMigrationState., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 10/19] Call init handler of event-tap at main() in vl.c., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer()., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 11/19] ioport: insert event_tap_ioport() to ioport_write()., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state()., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush()., Yoshiaki Tamura, 2011/01/13
- [Qemu-devel] [PATCH 13/19] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async()., Yoshiaki Tamura, 2011/01/13