[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit |
Date: |
Fri, 21 Jan 2011 10:45:30 +0000 |
On Tue, Jan 18, 2011 at 12:06 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Tue, Jan 18, 2011 at 11:39 AM, Kevin Wolf <address@hidden> wrote:
>> Am 18.01.2011 11:10, schrieb Stefan Hajnoczi:
>>> Provide the "removable" qdev property bit to override the SCSI INQUIRY
>>> removable (RMB) bit for non-CDROM devices. This will be used by USB
>>> Mass Storage Devices, which sometimes have this guest-visible bit set
>>> and sometimes do not. They therefore requires a means for user
>>> configuration.
>>>
>>> Signed-off-by: Stefan Hajnoczi <address@hidden>
>>
>> Should we print an error message when the user tries to make a CD-ROM
>> non-removable instead of silently ignoring the option?
>
> Good point. I will add a check in scsi_disk_initfn() for v3.
Actually this case is hard to check against. The removable property
is a boolean that defaults to false. We can't detect the difference
between default, cleared, or set.
I'm sending out a new version of the patch series that updates
docs/qdev-device-use.txt to describe how the removable property works.
Stefan
[Qemu-devel] [PATCH v2 2/3] scsi: Allow SCSI devices to override the removable bit, Stefan Hajnoczi, 2011/01/18
[Qemu-devel] [PATCH v2 3/3] usb-msd: Propagate removable bit to SCSI device, Stefan Hajnoczi, 2011/01/18