[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: add ppoll syscall support
From: |
Mike Frysinger |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: add ppoll syscall support |
Date: |
Sun, 23 Jan 2011 16:35:39 -0500 |
On Sun, Jan 23, 2011 at 16:25, Peter Maydell wrote:
> On 23 January 2011 19:56, Mike Frysinger wrote:
>> Some architectures (like Blackfin) only implement ppoll (and skip poll).
>> So add support for it using existing poll code.
>
> This looks wrong -- ppoll() is supposed to be atomic, but
> your implementation isn't. Why can't we just implement this
> by calling the host ppoll? (might need a configure test, but
> that's straightforward.)
it's atomic from the apps' point of view, so what does it matter ?
-mike