[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] pci: memory leak of PCIDevice::rom_file
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH] pci: memory leak of PCIDevice::rom_file |
Date: |
Mon, 24 Jan 2011 15:39:58 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 24, 2011 at 07:00:47PM +0900, Isaku Yamahata wrote:
> PCIDevice::rom_file is leaked.
> PCIDevice::rom_file is allocated in pci_qdev_init(), but not freed anywhere.
> free it in qemu_unregister_device().
>
> Signed-off-by: Isaku Yamahata <address@hidden>
Applied, thanks.
> ---
> hw/pci.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index b8f5385..044c4bd 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -833,6 +833,7 @@ static int pci_unregister_device(DeviceState *dev)
>
> pci_unregister_io_regions(pci_dev);
> pci_del_option_rom(pci_dev);
> + qemu_free(pci_dev->romfile);
> do_pci_unregister_device(pci_dev);
> return 0;
> }
> --
> 1.7.1.1