Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1

[Chunqiang Tang]

> On 20 January 2011 17:08, Stefan Weil <address@hidden> wrote:
> > Yes, that's a problem with some parts of the old code.
> > For files which you want to modify, you could remove
> > the spaces with your script before applying your other
> > modifications and create a separate patch which only
> > removes the superfluous spaces.
> 
> (This kind of came up in the other thread about fixing
> non-C89 comments. I don't have any particular interest in
> this area of the qemu source so this is a general remark.)
> 
> I definitely dislike patches which change whitespace or
> indentation for an entire file, even if they are standalone
> "only fixing whitespace" patches; they make it much harder
> to deal with forks and branches of qemu. I would prefer
> it if we only fix whitespace, indent and bracing for lines
> we're touching anyway.

I agree with this, i.e., only fixing the lines we are touching anyway. 
This is the approach the new series of FVD patches took.