[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() st
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement |
Date: |
Mon, 24 Jan 2011 17:10:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 |
On 01/24/11 17:08, Markus Armbruster wrote:
> address@hidden writes:
>
>> From: Jes Sorensen <address@hidden>
>>
>> Signed-off-by: Jes Sorensen <address@hidden>
>> ---
>> cutils.c | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/cutils.c b/cutils.c
>> index 369a016..8d562b2 100644
>> --- a/cutils.c
>> +++ b/cutils.c
>> @@ -324,26 +324,26 @@ int64_t strtosz_suffix(const char *nptr, char **end,
>> const char default_suffix)
>> }
>> }
>> switch (qemu_toupper(d)) {
>> - case 'B':
>> + case STRTOSZ_DEFSUFFIX_B:
>> mul = 1;
>> if (mul_required) {
>> goto fail;
>> }
>> break;
>> - case 'K':
>> + case STRTOSZ_DEFSUFFIX_KB:
>> mul = 1 << 10;
>> break;
>> case 0:
>> if (mul_required) {
>> goto fail;
>> }
>> - case 'M':
>> + case STRTOSZ_DEFSUFFIX_MB:
>> mul = 1ULL << 20;
>> break;
>> - case 'G':
>> + case STRTOSZ_DEFSUFFIX_GB:
>> mul = 1ULL << 30;
>> break;
>> - case 'T':
>> + case STRTOSZ_DEFSUFFIX_TB:
>> mul = 1ULL << 40;
>> break;
>> default:
>
> Phony abstraction. And it leaks: code here assumes the
> STRTOSZ_DEFSUFFIX_T* are all upper case.
qemu_toupper() - whats the problem?
Jes
- [Qemu-devel] [PATCH v4 0/4] strtosz() cleanups, Jes . Sorensen, 2011/01/24
- [Qemu-devel] [PATCH 2/4] strtosz() use qemu_toupper() to simplify switch statement, Jes . Sorensen, 2011/01/24
- [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes . Sorensen, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement,
Jes Sorensen <=
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes Sorensen, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes Sorensen, 2011/01/25
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/25
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes Sorensen, 2011/01/25
[Qemu-devel] [PATCH 3/4] strtosz(): Fix name confusion in use of modf(), Jes . Sorensen, 2011/01/24
[Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups, Kevin Wolf, 2011/01/24