qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] HACKING: Update status of format checking


From: Stefan Weil
Subject: [Qemu-devel] Re: [PATCH] HACKING: Update status of format checking
Date: Mon, 24 Jan 2011 19:07:03 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Iceowl/1.0b1 Icedove/3.0.11

Am 24.01.2011 18:40, schrieb Stefan Weil:
Hopefully all functions with printf like arguments now use format checking.

This was tested with default build configuration on linux
and windows hosts (including some cross compilations),
so chances are good that there remain few (if any) functions
without format checking.

Therefore the last comment in HACKING is no longer valid but misleading.

Cc: Blue Swirl<address@hidden>
Signed-off-by: Stefan Weil<address@hidden>
---
  HACKING |    3 ---
  1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/HACKING b/HACKING
index 6ba9d7e..3af53fd 100644
--- a/HACKING
+++ b/HACKING
@@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype.
  This makes it so gcc's -Wformat and -Wformat-security options can do
  their jobs and cross-check format strings with the number and types
  of arguments.
-
-Currently many functions in QEMU are not following this rule but
-patches to add the attribute would be very much appreciated.

Sorry, I did not send this patch to qemu-devel for review.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]