[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 12/23] ide: Remove unneeded null pointer check
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 12/23] ide: Remove unneeded null pointer check |
Date: |
Mon, 24 Jan 2011 22:10:41 +0100 |
From: Stefan Weil <address@hidden>
With bm == NULL, other code in the same function would crash.
This bug was reported by cppcheck:
hw/ide/pci.c:280: error: Possible null pointer dereference: bm
Cc: Michael S. Tsirkin <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
hw/ide/pci.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/hw/ide/pci.c b/hw/ide/pci.c
index 987caff..35168cb 100644
--- a/hw/ide/pci.c
+++ b/hw/ide/pci.c
@@ -267,9 +267,7 @@ static void bmdma_irq(void *opaque, int n, int level)
return;
}
- if (bm) {
- bm->status |= BM_STATUS_INT;
- }
+ bm->status |= BM_STATUS_INT;
/* trigger the real irq */
qemu_set_irq(bm->irq, level);
--
1.7.2.3
- [Qemu-devel] [PATCH 02/23] qemu-img snapshot: Use writeback caching, (continued)
- [Qemu-devel] [PATCH 02/23] qemu-img snapshot: Use writeback caching, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 03/23] do_snapshot_blkdev() error on missing snapshot_file argument, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 04/23] Make strtosz() return int64_t instead of ssize_t, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 05/23] Avoid divide by zero when there is no block device to migrate, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 06/23] ide: factor dma handling helpers, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 07/23] ide: also reset io_buffer_index for writes, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 08/23] ide: kill ide_dma_submit_check, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 09/23] qcow2: Add QcowCache, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 11/23] qcow2: Batch flushes for COW, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 10/23] qcow2: Use QcowCache, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 12/23] ide: Remove unneeded null pointer check,
Kevin Wolf <=
- [Qemu-devel] [PATCH 13/23] Documentation: Add qemu-img check/rebase, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 14/23] qed: Refuse to create images on block devices, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 15/23] Fix block migration when the device size is not a multiple of 1 MB, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 16/23] blockdev: Fix error message for invalid -drive CHS, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 17/23] blockdev: Make drive_init() use error_report(), Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 18/23] blockdev: Fix drive_del not to crash when drive is not in use, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 19/23] block: Use backing format driver during image creation, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 22/23] usb-msd: Propagate removable bit to SCSI device, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 20/23] scsi-disk: Allow overriding SCSI INQUIRY removable bit, Kevin Wolf, 2011/01/24
- [Qemu-devel] [PATCH 23/23] docs: Document scsi-disk and usb-storage removable parameter, Kevin Wolf, 2011/01/24