Re: [Qemu-devel] [PATCH V9 16/16] acpi-piix4: Add Xen hypercall for sleep state.

[Anthony PERARD]

On Wed, 26 Jan 2011, Isaku Yamahata wrote:

> On Tue, Jan 25, 2011 at 02:29:20PM +0000, address@hidden wrote:
> > From: Anthony PERARD <address@hidden>
> >
> > Signed-off-by: Anthony PERARD <address@hidden>
> > ---
> >  hw/acpi_piix4.c |    4 ++++
> >  hw/xen.h        |    2 ++
> >  xen-all.c       |    7 +++++++
> >  xen-stub.c      |    4 ++++
> >  4 files changed, 17 insertions(+), 0 deletions(-)
> >
> > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> > index 5bbc2b5..ea94bf9 100644
> > --- a/hw/acpi_piix4.c
> > +++ b/hw/acpi_piix4.c
> > @@ -23,6 +23,7 @@
> >  #include "acpi.h"
> >  #include "sysemu.h"
> >  #include "range.h"
> > +#include "xen.h"
> >
> >  //#define DEBUG
> >
> > @@ -181,6 +182,9 @@ static void pm_ioport_write(IORange *ioport, uint64_t 
> > addr, unsigned width,
> >                      if (s->cmos_s3) {
> >                          qemu_irq_raise(s->cmos_s3);
> >                      }
> > +                    if (xen_enabled()) {
> > +                        xen_set_hvm_sleep_state();
> > +                    }
> >                  default:
> >                      break;
> >                  }
>
> Why not utilize cmos_s3 callback?
> Something like
>
> -       cmos_s3 = qemu_allocate_irqs(pc_cmos_set_s3_resume, rtc_state, 1);
> +       cmos_s3 = qemu_allocate_irqs(xen_cmos_set_s3_resume, rtc_state, 1);
>         smbus = piix4_pm_init(pci_bus, piix3_devfn + 3, 0xb100,
>                               isa_reserve_irq(9), *cmos_s3, *smi_irq,
>                               kvm_enabled());
>
>
> xen_cmos_set_s3_resume()
>       pc_cmos_set_s3_resume()
>       xen_set_hvm_sleep_state()
>
>
> thanks,

I will do that and resend the patch. Thanks for this!

-- 
Anthony PERARD