[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N, i
From: |
Hannes Reinecke |
Subject: |
Re: [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N, intentional? |
Date: |
Fri, 28 Jan 2011 08:27:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101026 SUSE/3.0.10 Thunderbird/3.0.10 |
On 01/27/2011 08:26 PM, Gerd Hoffmann wrote:
> Hi,
>
>> } else if (!strcmp(buf, "scsi")) {
>> type = IF_SCSI;
>> - max_devs = MAX_SCSI_DEVS;
>> + max_devs = 7;
>
>> That's very obviously not much more than a hack, but I don't think
>> blockdev.c can get the real number easily (please prove me wrong). With
>> this hack, we would get the old behaviour for -drive (which doesn't use
>> any other controller anyway) and you can still use -device to attach
>> more devices to a non-lsi bus.
>
> Looks sensible to me. scsi controllers with more than 7 devs (megasas
> and whatever else might be coming, virtio?) can't be added via if=scsi
> legacy syntax and must use -blockdev and -device anyway.
>
> We probably want add a comment explaining this though.
>
Yes please. It's a bit non-obvious that 'scsi' means in fact 'lsi'.
As long as there a way of specifying more than 8 devs
I'm fine with that patch.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
address@hidden +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
- [Qemu-devel] Commit 622b520f changed -drive if=scsi, index=N, intentional?, Markus Armbruster, 2011/01/27
- [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N, intentional?, Kevin Wolf, 2011/01/27
- [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N, intentional?, Markus Armbruster, 2011/01/27
- Re: [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N, intentional?, Gerd Hoffmann, 2011/01/27
- Re: [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N, intentional?,
Hannes Reinecke <=
- Re: [Qemu-devel] Commit 622b520f changed -drive if=scsi, index=N, intentional?, Daniel P. Berrange, 2011/01/27
- [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N, intentional?, Paolo Bonzini, 2011/01/27