qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migr


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.
Date: Fri, 28 Jan 2011 13:58:37 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 01/28/2011 08:21 AM, Yoshiaki Tamura wrote:

+    /* check ft_mode option  */
+    p = strstr(uri, "ft_mode");
+    if (p&&  !strcmp(p, "ft_mode")) {
+        ft_mode = FT_INIT;
+    }
+

This works for TCP mode, but:

1) I am not sure what would happen with -incoming exec;

2) it is tricky! :) It works only because anything after the port is truncated by parse_host_port.

Is there any reason why the code cannot be in tcp_start_incoming_migration, where we know the URI has the right scheme? Alternatively you could put it _before_ the scheme, like "kemari:tcp:host:port".

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]