Re: [Qemu-devel] [PATCH] floppy: Parametrize ISA base and IRQ

[Andreas Färber]

Am 28.01.2011 um 13:41 schrieb Markus Armbruster:

> Andreas Färber <address@hidden> writes:
>
> > From: Hervé Poussineau <address@hidden>
> >
> > v1:
> > * Rebased.
>
> Patch versioning goes below the --- line, so it doesn't end up in git.

I disagree: I always put it into the commit message, so that we can  
see which version got committed and so that those that contributed  
ideas get credited.

In this case we can just scratch it.

> > Signed-off-by: Hervé Poussineau <address@hidden>
> > Signed-off-by: Andreas Färber <address@hidden>
> > ---
> > This patch allows to adapt the floppy device for the PReP Super I/O.
>
> Have we seen code for that?
>
> Patch rationale goes above the --- line, so it does end up in git.

It wasn't intended as such, since the Super I/O still depends on some  
controversial patches to PCI and qdev.

My WIP (based on Hervé's ppc branch) is here:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep

> > hw/fdc.c |   27 +++++++++++++++------------
> > 1 files changed, 15 insertions(+), 12 deletions(-)
>
> Patch looks good.

Thanks, will repost.

Andreas