[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] target-arm: Fix Neon VQ(R)SHRN instructions
From: |
Christophe Lyon |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] target-arm: Fix Neon VQ(R)SHRN instructions. |
Date: |
Mon, 7 Feb 2011 17:50:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7 |
On 07.02.2011 17:08, Peter Maydell wrote:
> On 31 January 2011 18:06, <address@hidden> wrote:
>> From: Christophe Lyon <address@hidden>
>>
>> Handle unsigned variant of VQ(R)SHRN instructions.
>
> This patch appears to be modifying a section of code
> that was already patched by 2/8 in this series. That's
> too confusing to review -- please combine them into
> one patch.
>
That's because I borrowed patch 2/8 from your meego tree. It was incomplete,
but as I preferred to keep it as-is, I completed it in a separate patch.
>From your other comments it looks like I'd have had better ignore the patches
>from Meego and rewrite the patches on my own ;-)