[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data |
Date: |
Tue, 8 Feb 2011 13:25:58 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Tue) 08 Feb 2011 [01:40:09], Anthony Liguori wrote:
> >
> >However, virtio doesn't have vmstate yet. Are we willing to put vmstate
> >in 0.14 to introduce subsections? I doubt that.
>
> Not, that's why I suggested reverting this change and pushing it to
> 0.15. We're not going to fix it properly in 0.14.
You mean reverting all of the flow control work? But then it exposes
another bug: a malicious guest doing huge writes will cause an OOM on
the host; it's better to have this fix rather than not have it.
Amit