[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case |
Date: |
Tue, 8 Feb 2011 12:39:05 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Fri, Feb 04, 2011 at 01:47:25PM -0200, Marcelo Tosatti wrote:
> From: Jan Kiszka <address@hidden>
>
> When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like
> it is done for KVM. Use the symbolic constants at this chance.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> Signed-off-by: Marcelo Tosatti <address@hidden>
> ---
> target-i386/helper.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
I don't feel very comfortable about this whole series (not in my
knowledge area), but as nobody else seems to care about 32-bit support,
I have committed this patch to master and the stable-0.14 tree.
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 1217452..f0c546d 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1147,8 +1147,8 @@ void cpu_inject_x86_mce(CPUState *cenv, int bank,
> uint64_t status,
> if (cenv == env) {
> continue;
> }
> -
> - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
> + qemu_inject_x86_mce(env, 1, MCI_STATUS_VAL | MCI_STATUS_UC,
> + MCG_STATUS_MCIP | MCG_STATUS_RIPV, 0, 0);
> }
> }
> }
> --
> 1.7.2.3
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 00/23] [PULL] qemu-kvm.git uq/master queue, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 19/23] kvm: Unconditionally reenter kernel after IO exits, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 18/23] Introduce VCPU self-signaling service, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 07/23] kvm: Report proper error on GET_VCPU_MMAP_SIZE failures, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 23/23] kvm: make tsc stable over migration and machine start, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 13/23] kvm: Refactor qemu_kvm_eat_signals, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 21/23] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case, Marcelo Tosatti, 2011/02/04
- Re: [Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 08/23] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 16/23] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 02/23] Stop current VCPU on synchronous reset requests, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 05/23] Leave inner main_loop faster on pending requests, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 20/23] kvm: Remove static return code of kvm_handle_io, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 10/23] kvm: Provide sigbus services arch-independently, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 15/23] Set up signalfd under !CONFIG_IOTHREAD, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 12/23] kvm: Set up signal mask also for !CONFIG_IOTHREAD, Marcelo Tosatti, 2011/02/04
- [Qemu-devel] [PATCH 06/23] Flatten the main loop, Marcelo Tosatti, 2011/02/04