[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->st
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->stopped is true |
Date: |
Wed, 09 Feb 2011 09:40:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-02-09 08:24, Paolo Bonzini wrote:
> On 02/08/2011 09:24 PM, Jan Kiszka wrote:
>> Hmm, does this path actually trigger? If yes, does it happen to obsolete
>> the global exit_request hack?
>
> No idea, I wanted to make the initial work as mechanical as possible. By
> inspection, cpu_stop_current is doing
>
> cpu_single_env->stopped = 1;
> cpu_exit(cpu_single_env);
>
> without setting ->stop. (I'm changing that in patch 7, but I'm setting
> ->stop to 0, not 1).
Checked my own patches again: :) exit_request is not obsoleted this way,
at least as long as we have !CONFIG_IOTHREAD hanging around.
Also, I don't see any compelling reason now why that test should be
unneeded. Rather, this looks like a sleeping race between asynchronous
and synchronous vcpu stop, probably papered over by polling the cond
variables so far.
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [CFT PATCH 01/12] io-thread: make sure to initialize qemu_work_cond and qemu_cpu_cond, (continued)
- [Qemu-devel] [CFT PATCH 03/12] inline cpu_halted into sole caller, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 09/12] do not use timedwait on qemu_system_cond, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 12/12] iothread stops the vcpu thread via IPI, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 02/12] cris, microblaze: use cpu_has_work, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->stopped is true, Paolo Bonzini, 2011/02/08
- Re: [Qemu-devel] [CFT PATCH 00/12] Tricky parts of my iothread-for-win32 stuff, Aurelien Jarno, 2011/02/08
- [Qemu-devel] [CFT PATCH 10/12] do not use timedwait on qemu_pause_cond, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 04/12] change qemu_thread_equal API to always compare with current thread, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 05/12] always qemu_cpu_kick after unhalting a cpu, Paolo Bonzini, 2011/02/08
- [Qemu-devel] Re: [CFT PATCH 00/12] Tricky parts of my iothread-for-win32 stuff, Jan Kiszka, 2011/02/08