[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/11] qcow2: Fix error handling for immediate backi
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 03/11] qcow2: Fix error handling for immediate backing file read failure |
Date: |
Thu, 10 Feb 2011 16:51:18 +0100 |
Requests could return success even though they failed when bdrv_aio_readv
returned NULL for a backing file read.
Reported-by: Chunqiang Tang <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/qcow2.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 28338bf..647c2a4 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -479,8 +479,10 @@ static void qcow2_aio_read_cb(void *opaque, int ret)
BLKDBG_EVENT(bs->file, BLKDBG_READ_BACKING_AIO);
acb->hd_aiocb = bdrv_aio_readv(bs->backing_hd, acb->sector_num,
&acb->hd_qiov, n1, qcow2_aio_read_cb, acb);
- if (acb->hd_aiocb == NULL)
+ if (acb->hd_aiocb == NULL) {
+ ret = -EIO;
goto done;
+ }
} else {
ret = qcow2_schedule_bh(qcow2_aio_read_bh, acb);
if (ret < 0)
--
1.7.2.3
- [Qemu-devel] [PULL 00/11] Block patches for master, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 03/11] qcow2: Fix error handling for immediate backing file read failure,
Kevin Wolf <=
- [Qemu-devel] [PATCH 02/11] QCOW2: bug fix - read base image beyond its size, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 01/11] Change snapshot_blkdev hmp to use correct argument type for device, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 05/11] qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 06/11] qcow2: Report error for version > 2, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 04/11] qcow2: Fix error handling for reading compressed clusters, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 08/11] qemu-img: Improve error messages for failed bdrv_open, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 09/11] blockdev: Plug memory leak in drive_uninit(), Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 10/11] blockdev: Plug memory leak in drive_init() error paths, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 07/11] qed: Report error for unsupported features, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 11/11] qcow2: Fix order in L2 table COW, Kevin Wolf, 2011/02/10