Re: [Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper function

[Nathan Froyd]

On Fri, Feb 11, 2011 at 05:12:32PM +0000, Peter Maydell wrote:
> On 11 February 2011 17:03, Nathan Froyd <address@hidden> wrote:
> > I do think the preferred way would be to extract rd, rm, size, and Q
> > up-front, rather than having the helper twiddle instruction bits.
> 
> OK. You're happy to still have the helper do the reading and
> writing of env->vfp.regs[] directly, though?

I think you can make a case either way, but you're passing enough values
already that accessing env->vfp.regs directly in the helper seems
reasonable.

-Nathan