qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [V5 PATCH 2/8] virtio-9p: Provide chroot environment se


From: Stefan Hajnoczi
Subject: [Qemu-devel] Re: [V5 PATCH 2/8] virtio-9p: Provide chroot environment server side interfaces
Date: Thu, 17 Feb 2011 08:54:08 +0000
User-agent: Mutt/1.5.20 (2009-06-14)

On Wed, Feb 16, 2011 at 05:53:09PM +0530, M. Mohan Kumar wrote:
> +static int chroot_daemonize(int chroot_sock)
> +{
> +    sigset_t sigset;
> +    struct rlimit nr_fd;
> +    int fd;
> +
> +    /* Block all signals for this process */
> +    sigprocmask(SIG_SETMASK, &sigset, NULL);

sigset is an uninitialized local variable so the result of this is
undefined.  We're missing sigfillset(&sigset).

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]