Re: [Qemu-devel] [PATCH 2/7] iohandlers: Introduce a new API

[Amit Shah]

On (Tue) 22 Feb 2011 [14:39:03], Alon Levy wrote:
> On Tue, Feb 22, 2011 at 03:48:31PM +0530, Amit Shah wrote:
> > Introduce a new iohandler api that doesn't have multiple callbacks.
> > Instead, a single callback and a mask of events that got set will be
> > passed on to the handler.  This will ease our transition to a poll()
> > interface instead of the current select() that happens on the fds.
> 
> Is the mask argument to the callback indicative of a real mask, or is
> this an enum when passed to the clients? i.e. you seem to use a switch
> in all handlers, so is it actually meant that each callback has a single
> possible value, not an or'ed one?

Hm, this will actually be a bug when we get rid of the _can_read
callbacks.  So the switch will have to change to something else for
sure.

                Amit