[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 21/28] migration: Make state definitions local
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 21/28] migration: Make state definitions local |
Date: |
Thu, 24 Feb 2011 10:01:50 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Yoshiaki Tamura <address@hidden> wrote:
> 2011/2/24 Juan Quintela <address@hidden>:
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> migration.c | 8 ++++++++
>> migration.h | 8 --------
>> 2 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/migration.c b/migration.c
>> index 493c2d7..697c74f 100644
>> --- a/migration.c
>> +++ b/migration.c
>> @@ -31,6 +31,14 @@
>> do { } while (0)
>> #endif
>>
>> +enum migration_state {
>> + MIG_STATE_ERROR,
>
> Would be better to say:
>
> MIG_STATE_ERROR = -1,
I thought about it, but basically it shouldn't matter, no?
Later, Juan.
- [Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly, (continued)
- [Qemu-devel] [PATCH 17/28] migration: another case of global variable assigned to local one, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 18/28] migration: convert current_migration from pointer to struct, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 19/28] migration: Use bandwidth_limit directly, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 07/28] migration: move migrate_create_state to do_migrate, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 20/28] migration: Export a function that tells if the migration has finished correctly, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 21/28] migration: Make state definitions local, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 05/28] migration: Refactor MigrationState creation, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 23/28] migration: add error handling to migrate_fd_put_notify()., Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 22/28] savevm: avoid qemu_savevm_state_iteate() to return 1 when qemu file has error., Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 24/28] migration: Don't use callback on file defining it, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 25/28] migration: propagate error correctly, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 26/28] migration: qemu_savevm_iterate has three return values, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 27/28] migration: If there is one error, it makes no sense to continue, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 28/28] migration: make migration-{tcp, unix} consistent, Juan Quintela, 2011/02/23
- [Qemu-devel] [PATCH 11/28] migration: Introduce migrate_fd_completed() for consistenncy, Juan Quintela, 2011/02/23