[Qemu-devel] Re: [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu

[Markus Armbruster]

Juan Quintela <address@hidden> writes:

> Markus Armbruster <address@hidden> wrote:
>> Peter Maydell <address@hidden> writes:
>>
>>> On 24 February 2011 10:33, Juan Quintela <address@hidden> wrote:
>>>> +# shared-obj-y has the object that are shared by qemu binary and tools
>>>> +
>>>> +shared-obj-y  = qemu-error.o $(block-obj-y) $(qobject-obj-y) 
>>>> $(oslib-obj-y)
>>>> +shared-obj-y += qemu-timer-common.o
>>>
>>> I don't feel very strongly about this, but:
>>> It seems a bit odd to have a shared-obj-y variable that isn't actually
>>> a list of shared objects (ie .so files, DLLs). Maybe there's a better name?
>>
>> common-obj-y?
>
> already taken :-(
>
> common-obj-y is the list of files that are shared by all qemu-softmmu
>
> ######################################################################
> # libqemu_common.a: Target independent part of system emulation. The
> # long term path is to suppress *all* target specific code in case of
> # system emulation, i.e. a single QEMU executable should support all
> # CPUs and machines.
> common-obj-y = $(block-obj-y) blockdev.o
> ...
>
> so, this is the list of files that are shared between all the softmmu
> (common) and the tools.
>
> I am open to suggestions, but all names I thought are worse than shared
> (common-common-obj-y) :p

really-common-obj-y?  ;)

Seriously, what about renaming common-obj-y away?  target-indep-obj-y?