[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] target-arm: Use TCG temporary leak debuggin
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] target-arm: Use TCG temporary leak debugging facilities |
Date: |
Fri, 25 Feb 2011 15:48:18 +0000 |
On 25 February 2011 15:32, Blue Swirl <address@hidden> wrote:
> On Wed, Feb 23, 2011 at 5:19 PM, Peter Maydell <address@hidden> wrote:
>> +
>> + if (tcg_check_temp_count()) {
>> + fprintf(stderr, "TCG temporary leak before %08x\n", dc->pc);
>> + }
>
> Perhaps this check and tcg_clear_temp_count() calls should be added
> instead to tb_gen_code() in exec.c, to benefit all targets at once. PC
> information will not be as accurate, though.
You'd get a pile of false positives, for instance target-arm doesn't
bother to destroy the whole-TB temporaries like cpu_F0s because there's
no need to. We're trying to check whether the translator could
unboundedly leak temporaries...
-- PMM