Re: [Qemu-devel] Re: [PATCH][STABLE-0.14] vnc: tight: Fix crash after 2GB of output

[Michael Tokarev]

05.03.2011 11:33, Corentin Chary wrote:
> On Sat, Mar 5, 2011 at 6:56 AM, Michael Tokarev <address@hidden> wrote:
>> 05.03.2011 00:08, Corentin Chary wrote:

>> What's wrong with using an attachment?  The whole email can be
>> fed into patch(1) (or git-am, whatever) and either will do the
>> job.  But here it goes, anyway, with one possible caveat - I'm
>> not sure anymore it will apply, since now I used cut-n-paste.

> It's easier for reviewer because it allow people to view and comment
> the code directly in a mail client.

I can usually easily review patches sent as text/plain attachments
directly in my client.  But granted, I tried to reply to my own
email with attachment and Thunderbird does not show the patch text, --
it usually does.  I'll investigate it.  But the patch is shown
inline as the rest of my email, so it's still easy to review it
(but not comment on individual parts).

In any way, this patch is too simple to comment on it.

> The prefered way to send patch is `git format-patch` and `git
> send-email`. If you use these two tools, you can be sure that all will
> be ok :).

Now please show me how I can use these tools when replying to
a discussion and keeping other comments and thread flow.  Yes
sure this can be done, I can cut-n-paste all sorts of original
message into the editor executed by git send-email, or even into
command-line of git format-patch, but this is just too much work
compared with regular reply in usual mail client and attaching
a single file.  The latter is much more productive and as easy
to review and apply, the only difference is - as it turns out -
in-line commenting, but I'll check this separately.

What I miss in Thunderbird is a way to _insert_ content of a
file into the message, -- a combination of cut-n-paste and
attachment.  With sufficient care I can keep tabs after
cut-n-paste, but this is fragile.  If I can solve inline-
comments in attached patch that'll be ideal variant.

And I think that the reasons you stated above are not
sufficient to warrant re-sending this very patch as
you asked me to do... ;)

Thanks!

/mjt