Re: [Qemu-devel] [PATCH 10/17] s390x: Adjust GDB stub

[Alexander Graf]

On 25.03.2011, at 13:07, Nathan Froyd wrote:

> On Thu, Mar 24, 2011 at 04:58:46PM +0100, Alexander Graf wrote:
>> We have successfully lazilized cc computation, so we need to manually
>> trigger its calculation when gdb wants to fetch it. We also changed the
>> variable name, so writing it writes into a different field now.
> 
> Wouldn't you want to:
> 
> a) change the variable name in the earlier commit and just do the
>   manual triggering in this commit, so as not to break bisect; or
> b) combine this change with the previous lazification?

I mostly did the variable name change so I can easily track all users of cc and 
adjust them accordingly.

The nice position we're in with S/390 is that nobody is building it currently. 
And even if they were, it would just break as compilation has been broken for 
quite a while now (ivshmem). So I basically assume that the target is only 
enabled for real bisecting as of the last patch which enables its configuration 
in the default target list.


Alex