qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple


From: Avi Kivity
Subject: Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple
Date: Mon, 04 Apr 2011 19:35:25 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.9

On 04/04/2011 07:22 PM, Anthony Liguori wrote:
On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote:
On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote:
Many PCI BARs that use the memory address space map a single MMIO region into the entire BAR range. Introduce an API pci_register_bar_simple() for that use
case, and convert all users where this can be done trivially.

This will reduce the work required to introduce a PCI memory API; it's also
a nice code reduction in its own right.
This will save some code, so
Acked-by: Michael S. Tsirkin<address@hidden>

I really hope the rest of devices will follow.

How complete is this?

I converted all devices which were easy to convert. There may be one or two more that can be converted with additional work (and perhaps with an additional pic_bar_get_current_address() API, and a pci_bar_set_coalescing() API). The rest likely need to stick with the callback-based API.

--
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]